test: migrate tests to Python3 by default #32685

compnerd · 2020-07-02T17:49:44Z

This changes the python interpreter used to invoke the tests to Python3.
Python2 has been EOL'ed by the Python Software Foundation. This
migration enables the Swift test suite to run with Python 3 instead.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

compnerd · 2020-07-02T17:50:06Z

CC: @tachoknight @drexin @shahmishal

compnerd · 2020-07-02T17:50:36Z

This is basically to gauge how the CI systems will take to this. I still have a few failures locally that need to be investigated.

compnerd · 2020-07-02T17:50:45Z

@swift-ci please clean test

swift-ci · 2020-07-02T18:59:07Z

Build failed
Swift Test Linux Platform
Git Sha - 593b496eaae148ce173d1e13ea64924722e7bbd1

swift-ci · 2020-07-02T19:21:56Z

Build failed
Swift Test OS X Platform
Git Sha - 593b496eaae148ce173d1e13ea64924722e7bbd1

compnerd · 2020-07-09T00:01:55Z

@swift-ci please test windows platform

compnerd · 2020-07-09T21:10:51Z

@swift-ci please test Windows platform

compnerd · 2020-07-09T21:52:43Z

@swift-ci please test Linux platform

swift-ci · 2020-07-10T00:14:22Z

Build failed
Swift Test Linux Platform
Git Sha - 593b496eaae148ce173d1e13ea64924722e7bbd1

compnerd · 2020-07-10T14:57:09Z

@swift-ci please test windows platform

compnerd · 2020-07-10T21:39:04Z

@swift-ci please test Windows platform

compnerd · 2020-07-10T21:46:08Z

Please test with following PRs:
apple/llvm-project#1443

@swift-ci please test Linux platform

swift-ci · 2020-07-10T22:35:32Z

Build failed
Swift Test Linux Platform
Git Sha - 593b496eaae148ce173d1e13ea64924722e7bbd1

compnerd · 2020-07-10T22:49:27Z

Please test with following PRs:
apple/llvm-project#1443

@swift-ci please test macOS platform

compnerd · 2020-07-10T22:51:48Z

Please test with following PRs:
apple/llvm-project#1443

@swift-ci please smoke test Linux platform

swift-ci · 2020-07-10T23:33:50Z

Build failed
Swift Test OS X Platform
Git Sha - 593b496eaae148ce173d1e13ea64924722e7bbd1

compnerd · 2020-07-10T23:45:18Z

Please test with following PRs:
apple/llvm-project#1443

@swift-ci please test macOS platform

swift-ci · 2020-07-11T00:42:43Z

Build failed
Swift Test OS X Platform
Git Sha - 593b496eaae148ce173d1e13ea64924722e7bbd1

compnerd · 2020-07-11T19:16:38Z

@swift-ci please test Linux platform

swift-ci · 2020-07-11T20:26:49Z

Build failed
Swift Test Linux Platform
Git Sha - 593b496eaae148ce173d1e13ea64924722e7bbd1

compnerd · 2020-07-13T16:16:12Z

Please test with following PRs:
apple/llvm-project#1445

@swift-ci please test Linux platform

swift-ci · 2020-07-13T17:45:39Z

Build failed
Swift Test Linux Platform
Git Sha - 593b496eaae148ce173d1e13ea64924722e7bbd1

compnerd · 2020-07-13T17:54:03Z

Please test with following PRs:
apple/llvm-project#1445

@swift-ci please test macOS platform

swift-ci · 2020-07-13T19:11:42Z

Build failed
Swift Test OS X Platform
Git Sha - 593b496eaae148ce173d1e13ea64924722e7bbd1

compnerd · 2020-07-13T23:55:57Z

Please test with following PRs:
apple/llvm-project#1445

@swift-ci please test Linux platform

swift-ci · 2020-07-14T00:46:22Z

Build failed
Swift Test Linux Platform
Git Sha - 593b496eaae148ce173d1e13ea64924722e7bbd1

compnerd · 2020-07-14T04:04:24Z

Please test with following PRs:
apple/llvm-project#1445

@swift-ci please test Linux platform

swift-ci · 2020-07-14T05:20:08Z

Build failed
Swift Test Linux Platform
Git Sha - 593b496eaae148ce173d1e13ea64924722e7bbd1

compnerd · 2020-07-14T15:52:18Z

Please test with following PRs:
apple/llvm-project#1445

@swift-ci please test macOS platform

compnerd · 2020-08-13T19:31:09Z

@swift-ci please test CentOS 7 platform

compnerd · 2020-08-14T02:12:20Z

@swift-ci please test CentOS 7 platform

compnerd · 2020-08-14T04:57:32Z

@swift-ci please test Amazon Linux 2 Platform

swift-ci · 2020-08-14T11:25:52Z

Build failed
Swift Test Amazon Linux 2 Platform
Git Sha - b99861a3f73dae906cc4ff5f1a9851087c199d83

compnerd · 2020-08-14T14:52:04Z

@swift-ci please test Amazon Linux 2 Platform

swift-ci · 2020-08-14T19:49:01Z

Build failed
Swift Test Amazon Linux 2 Platform
Git Sha - b99861a3f73dae906cc4ff5f1a9851087c199d83

drexin · 2020-08-17T06:01:39Z

@swift-ci please test Amazon Linux 2 Platform

swift-ci · 2020-08-17T07:41:32Z

Build failed
Swift Test Amazon Linux 2 Platform
Git Sha - b99861a3f73dae906cc4ff5f1a9851087c199d83

drexin · 2020-08-17T22:43:48Z

@swift-ci please clean test Amazon Linux 2 Platform

swift-ci · 2020-08-18T00:28:54Z

Build failed
Swift Test Amazon Linux 2 Platform
Git Sha - b99861a3f73dae906cc4ff5f1a9851087c199d83

This changes the python interpreter used to invoke the tests to Python3. Python2 has been EOL'ed by the Python Software Foundation. This migration enables the Swift test suite to run with Python 3 instead.

drexin · 2020-08-18T20:26:20Z

@swift-ci please test Amazon Linux 2 Platform

shahmishal · 2020-08-18T20:27:32Z

@swift-ci smoke test

shahmishal · 2020-08-18T20:27:52Z

@swift-ci test

shahmishal · 2020-08-18T20:28:06Z

@swift-ci smoke test

compnerd · 2020-08-18T21:00:36Z

@swift-ci please test Windows platform

swift-ci · 2020-08-18T21:58:24Z

Build failed
Swift Test OS X Platform
Git Sha - 17c8d27

compnerd · 2020-08-18T22:40:42Z

@shahmishal seems that the macOS builders are missing flake8?

--
: 'RUN: at line 8';   /Applications/Xcode-beta.app/Contents/Developer/usr/bin/python3 /Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/utils/python_lint.py
--
Exit Code: 1

Command Output (stdout):
--

The flake8 and flake8-import-order Python packages are required for linting,
but these were not found on your system.

You can install these using:

    python -m pip install flake8
    python -m pip install flake8-import-order

For more help, see http://flake8.pycqa.org.


--

********************

shahmishal · 2020-08-18T22:48:53Z

Checking why macOS-64 is missing the module

shahmishal · 2020-08-18T22:52:52Z

Node updated:

xcrun python3 -m flake8 --version
3.8.3 (import-order: 0.18.1, mccabe: 0.6.1, pycodestyle: 2.6.0, pyflakes: 2.2.0) CPython 3.8.2 on Darwin

shahmishal · 2020-08-18T22:53:02Z

@swift-ci test macOS

swift-ci · 2020-08-19T01:33:42Z

Build failed
Swift Test Amazon Linux 2 Platform
Git Sha - 17c8d27

drexin · 2020-08-20T22:19:58Z

@swift-ci test amazon linux 2

swift-ci · 2020-08-21T00:01:19Z

Build failed
Swift Test Amazon Linux 2 Platform
Git Sha - 17c8d27

drexin · 2020-08-21T00:47:30Z

@swift-ci test amazon linux 2

compnerd · 2020-08-24T23:16:47Z

@shahmishal - this is ready to go whenever you are

shahmishal · 2020-08-26T20:04:04Z

Thanks @compnerd and @drexin!

compnerd marked this pull request as draft July 2, 2020 17:49

test: migrate tests to Python3 by default

17c8d27

This changes the python interpreter used to invoke the tests to Python3. Python2 has been EOL'ed by the Python Software Foundation. This migration enables the Swift test suite to run with Python 3 instead.

compnerd force-pushed the testing-the-future branch from b99861a to 17c8d27 Compare August 18, 2020 20:24

shahmishal merged commit b37de4b into apple:master Aug 26, 2020

compnerd deleted the testing-the-future branch August 26, 2020 20:07

test: migrate tests to Python3 by default #32685

test: migrate tests to Python3 by default #32685

Conversation

compnerd commented Jul 2, 2020

compnerd commented Jul 2, 2020

compnerd commented Jul 2, 2020

compnerd commented Jul 2, 2020

swift-ci commented Jul 2, 2020

swift-ci commented Jul 2, 2020

compnerd commented Jul 9, 2020

compnerd commented Jul 9, 2020

compnerd commented Jul 9, 2020

swift-ci commented Jul 10, 2020

compnerd commented Jul 10, 2020

compnerd commented Jul 10, 2020

compnerd commented Jul 10, 2020

swift-ci commented Jul 10, 2020

compnerd commented Jul 10, 2020

compnerd commented Jul 10, 2020

swift-ci commented Jul 10, 2020

compnerd commented Jul 10, 2020

swift-ci commented Jul 11, 2020

compnerd commented Jul 11, 2020

swift-ci commented Jul 11, 2020

compnerd commented Jul 13, 2020

swift-ci commented Jul 13, 2020

compnerd commented Jul 13, 2020

swift-ci commented Jul 13, 2020

compnerd commented Jul 13, 2020

swift-ci commented Jul 14, 2020

compnerd commented Jul 14, 2020

swift-ci commented Jul 14, 2020

compnerd commented Jul 14, 2020

compnerd commented Aug 13, 2020

compnerd commented Aug 14, 2020

compnerd commented Aug 14, 2020

swift-ci commented Aug 14, 2020

compnerd commented Aug 14, 2020

swift-ci commented Aug 14, 2020

drexin commented Aug 17, 2020

swift-ci commented Aug 17, 2020

drexin commented Aug 17, 2020

swift-ci commented Aug 18, 2020

drexin commented Aug 18, 2020

shahmishal commented Aug 18, 2020

shahmishal commented Aug 18, 2020

shahmishal commented Aug 18, 2020

compnerd commented Aug 18, 2020

swift-ci commented Aug 18, 2020

compnerd commented Aug 18, 2020

shahmishal commented Aug 18, 2020

shahmishal commented Aug 18, 2020

shahmishal commented Aug 18, 2020

swift-ci commented Aug 19, 2020

drexin commented Aug 20, 2020

swift-ci commented Aug 21, 2020

drexin commented Aug 21, 2020

compnerd commented Aug 24, 2020

shahmishal commented Aug 26, 2020