[master] Apple Silicon support #32705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the changes fall into a few categories: * Replace explicit "x86_64" with %target-cpu in lit tests * Cope with architecture differences in IR/asm/etc. macOS-specific tests
…n macOS. Most of this is enabled by an upstream change to generalize the tests for the api-digester to properly handle all targets. The primary change here is to account for the Swift-level ABI differences for the standard library between Apple Silicon macOS and Intel macOS. Specifically, anything related to Float80 will be removed from the standard library on Apple Silicon macOS, so account for the differences.
…lgen) from the native build
…iling clang and compiler-rt are rev-locked and should match. Currently, we build clang (and use it to bootstrap the rest) but don't build compiler-rt. We should. This doesn't completely achieve that: this only makes us build compiler-rt for the local host. This used to be pretty much impossible, but, since then, compiler-rt cmake support was rewritten. We should build it for the other hosts as well, but that's trickier, because we'd need to make the cross-compiled compiler-rt build use a separate just-built clang (from the local host). We do that for the other projects, but compiler-rt is special (because it's cmake'd as a runtime part of clang/llvm).
…acy-impl. LIPO_SRC_DIRS wasn't set for '--only-execute merged-hosts-lipo', because the logic was skipped for actions other than install.
… building stdlib at all
…n for arm64 macOS
… and watchOS 7.0.
LLVM no longer canonicalizes target triples for maOS versions. Update tests to account for this.
|
@swift-ci test |
shahmishal
changed the title
|
Build failed |
|
Build failed |
|
The bot failed because automerger is currently blocked. |
AliSoftware
reviewed
Jul 4, 2020
|
@swift-ci test |
| ${SWIFT_OSX_SDK_VERSION} STREQUAL "10.15") | ||
| set(SUPPORTED_OSX_ARCHS "x86_64") | ||
| else() | ||
| set(SUPPORTED_OSX_ARCHS "x86_64;arm64e") |
There was a problem hiding this comment.
Should this include arm64 like line 17?
There was a problem hiding this comment.
Going to file a bugs.swift.org and follow up in the future PR. SR-13144
There was a problem hiding this comment.
This bit of code should be dead now
xwu
reviewed
Jul 4, 2020
xwu
reviewed
Jul 4, 2020
Co-authored-by: Olivier Halligon <olivier@halligon.net>
Co-authored-by: Xiaodi Wu <13952+xwu@users.noreply.github.com>
Co-authored-by: Xiaodi Wu <13952+xwu@users.noreply.github.com>
|
Full test was already done, going to only run smoke test for comment update. |
|
@swift-ci smoke test |
|
Full test results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.