Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sema] Mark the direct callee as being a callee for all ApplyExprs not just CallExprs #32737

Merged
merged 1 commit into from Jul 7, 2020
Merged

Conversation

vukrado
Copy link
Contributor

@vukrado vukrado commented Jul 7, 2020

This pull request will mark the direct callee as being a callee if an Expr is any ApplyExpr instead of just for CallExprs.

This was preventing the FunctionRefKind for an operator call to be SingleApply, which ultimately did not introduce a disjunction choice for an implicitly unwrapped return value.

Resolves: SR-11399.
Resolves: rdar://problem/55042628

@xedin xedin self-requested a review July 7, 2020 05:12
Copy link
Member

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thank you!

@xedin
Copy link
Member

xedin commented Jul 7, 2020

@swift-ci please smoke test

@xedin xedin changed the title [TypeCheckConstraints] Mark the direct callee as being a callee for all ApplyExprs not just CallExprs [Sema] Mark the direct callee as being a callee for all ApplyExprs not just CallExprs Jul 7, 2020
@LucianoPAlmeida
Copy link
Collaborator

CI failures seems unrelated, try to kick it again :)

@LucianoPAlmeida
Copy link
Collaborator

@swift-ci Please smoke test Windows platform

@LucianoPAlmeida
Copy link
Collaborator

@swift-ci Please smoke test MacOS platform

Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants