[build] Remove unemployed 'skip-{build,test}-*' flags from build-script-impl #33154
Conversation
…pt-impl These flags have done nothing for awhile, as 26 of 31 have already been moved to build-script. Only the flags related to haiku, maccatalyst, and external-benchmarks are unrecognized by either build script after this removal.
|
@edymtt can probably review this change. I'm no longer working on the Swift project. |
|
@bitjammer, looks like you added a lot of these flags, review requested. |
|
I haven't edited this file since it was reorganized some years ago. I recommend asking @shahmishal if he or someone else can review on this one. Thanks! |
|
@swift-ci smoke test |
|
@swift-ci build toolchain |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
macOS Toolchain Install command |
|
@swift-ci please smoke test Linux platform |
|
@buttaface You can remove all of the cmake build benchmark external. |
| @@ -560,9 +560,6 @@ class BuildScriptInvocation(object): | |||
| impl_args += ["--skip-build"] | |||
| if not args.build_benchmarks: | |||
| impl_args += ["--skip-build-benchmarks"] | |||
| # Currently we do not build external benchmarks by default. | |||
| if args.build_external_benchmarks: | |||
| impl_args += ["--skip-build-freebsd"] | ||
| if not args.build_cygwin: | ||
| impl_args += ["--skip-build-cygwin"] | ||
| if not args.build_osx: |
There was a problem hiding this comment.
Does this really not do anything? I am pretty sure I have used these in the past bit.
There was a problem hiding this comment.
All bash flags in this pull were removed because I could find no trace of them being used in the bash script |
|
Ping, ready to go? |
|
Ping @shahmishal, ready to merge, though you may need to rerun the CI with the latest commit from the main branch first. |
|
@swift-ci test and merge |
These flags have done nothing for awhile, as 26 of 31 have already been moved to
build-script. Only the flags related to haiku, maccatalyst, and external-benchmarks are unrecognized by either build script after this removal.I just checked to see if
--skip-build-linuxwould disable building all products for that platform, as I've been doing manually when cross-compiling the toolchain for Android, and was surprised to find that the flag did nothing inbuild-script-impl. I investigated further and found that these 30 flags do nothing too, as most of them have been moved tobuild-scriptand their functionality removed from the bash script, eg #26495.The haiku-related functionality has been swept aside over time, while maccatalyst never did anything, maybe because the actual implementation hasn't been open-sourced? I noticed that another flag from that Catalyst pull does nothing, but didn't remove it here.
@gottesmm, all the implementation of
--build-external-benchmarkshas been moved tobuild-scriptand the Python scripts. You could add back a--skip-build-external benchmarksthere that actually works, but since the default is to skip it, probably not needed.@Rostepher, review requested.