Refactor manual size calculations to use totalSizeToAlloc #33256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@varungandhi-apple can you look over this? thanks |
Yeah, I intended the fix to be only for places sub-classing from |
varungandhi-apple
approved these changes
Aug 3, 2020
|
@swift-ci please test |
Refactor manual size calculations in getImportSet Refactor manual size calculations in Enum Declaration::create Refactor manual size calculations in memory allocation on SequenceExpr::create Refactor manual size calculations in memory allocation Refactor manual size calculations in memory allocation
|
@varungandhi-apple since all tests passed here, i squashed the commit and should be good to go. thank you! |
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor some of the compiler methods which are using manual calculations for allocating memory. Since some of the compiler classes do not extend the TrailingObjects class as a friend class, I assumed that this requires more than a "StarterBug" experience.
Resolves SR-13246.