[SR-13359] [Sema] Tailored diagnostics for missing subscript members on tuple type base #33380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucianoPAlmeida
force-pushed
the
SR-13359-subscript-tuple
branch
from
0f4b9f1
to
99a011e
Compare
…ubscripts on tuple base types
LucianoPAlmeida
force-pushed
the
SR-13359-subscript-tuple
branch
from
99a011e
to
0d5bfcb
Compare
varungandhi-apple
suggested changes
Aug 9, 2020
theblixguy
reviewed
Aug 9, 2020
…teral within bounds of tuple elements
…tring literals that matches a label of labeled tuples
LucianoPAlmeida
force-pushed
the
SR-13359-subscript-tuple
branch
from
681f8b1
to
e8f1784
Compare
|
@swift-ci please smoke test |
theblixguy
reviewed
Aug 10, 2020
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows Platform |
xedin
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Looks great, thank you, @LucianoPAlmeida! I have left a couple of minor notes inline.
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows Platform |
xedin
reviewed
Aug 11, 2020
LucianoPAlmeida
force-pushed
the
SR-13359-subscript-tuple
branch
from
1f45291
to
d62e9dd
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows Platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a tailored diagnostic for missing subscript members on tuple type base.
Resolves SR-13359.