Add a SWIFT_STDLIB_STABLE_ABI flag to be able to build the stdlib without -enable-library-evolution #33443
Conversation
kubamracek
requested review from
compnerd,
jckarter,
gottesmm and
devincoughlin
|
The SWIFT_STDLIB_STABLE_ABI=0 setting should also be used on Linux, but I'm intentionally not flipping the default with this PR, and keeping it for a subsequent change (because it's likely to need some test adjustments). |
|
@swift-ci please test |
Why? |
|
Build failed |
|
@kubamracek I think this is too strong of a condition to set a default of true. Consider porting swift to a new platform or that many of the platforms swift builds for do not have a stable ABI. Also, we don't have a stable ABI on Linux today and do not want that to go into tree. So can we do that in this PR? At least with the swift-ci preset? |
|
I am not sure what the right solution is btw with respect to how to determine the default value here. But TRUE makes me nervous. |
|
Turning library evolution off by default seems reasonable. I think that's good for setting expectations for new platforms, since establishing a stable ABI is a project to itself on top of doing the initial porting work. |
|
I'm pretty sure we today build all platforms' stdlib with library evolution on. So it sounds like that as a preliminary step, we should turn it off for everything except Darwin? |
…hout -enable-library-evolution
kubamracek
force-pushed
the
stdlib-stable-abi
branch
from
c3b6219
to
07b6ad0
Compare
|
@swift-ci please test |
|
Updated this PR to just introduce the "knob" to turn resilience on or off (SWIFT_STDLIB_STABLE_ABI). Made all currently supported platforms have the knob "on", even when it's technically not true, and marked those cases with a FIXME comment. Now we can separately work on turning the knob when applicable. |
|
@swift-ci please test Windows platform |
|
@harlanhaskins @jckarter @gottesmm looks good now? |
|
LGTM! |
No description provided.