[AutoDiff] [Sema] Include certain 'let' properties in 'Differentiable' derived conformances. #33700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
changed the title
rxwei
force-pushed
the
SR-13474-differentiable-class-let
branch
from
4842e0e
to
694e691
Compare
…' derived conformances.
Today, `let` properties are treated as if they had `@noDerivative` and
excluded from the derived `Differentaible` conformance implementation.
This is limiting to properties that have a non-mutating `move(along:)`
(e.g. class properties), which can be mathematically treated as
differentiable variables.
This patch changes the derived conformances behavior such that `let`
properties will be included as differentiable variables if they have a
non-mutating 'move(along:)'. This unblocks the following code:
```swift
class Foo: Differentiable {
let x: ClassStuff // Class type
// Synthesized code:
// struct TangentVector {
// var x: ClassStuff.TangentVector
// }
// ...
// func move(along direction: TangentVector) {
// x.move(along: direction.x)
// }
}
```
Resolves SR-13474 (rdar://67982207).
rxwei
force-pushed
the
SR-13474-differentiable-class-let
branch
from
694e691
to
702f738
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today,
letproperties are treated as if they had@noDerivativeand excluded from the derivedDifferentiableconformance implementation. This is limiting to properties that have a non-mutatingmove(along:)(e.g. class properties), which can be mathematically treated as differentiable variables.This patch changes the derived conformances behavior such that
letproperties will be included as differentiable variables if they have a non-mutatingmove(along:). This unblocks the following code:Resolves SR-13474 (rdar://67982207).