Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Fix glibc.modulemap generation #33899

Merged
merged 1 commit into from
Sep 11, 2020
Merged

[5.3] Fix glibc.modulemap generation #33899

merged 1 commit into from
Sep 11, 2020

Conversation

drexin
Copy link
Member

@drexin drexin commented Sep 11, 2020 •
edited

Cherry pick of #33311

@drexin drexin added the r5.3 label Sep 11, 2020
@drexin drexin requested a review from a team as a code owner September 11, 2020 00:17
@drexin
Copy link
Member Author

drexin commented Sep 11, 2020

@swift-ci clean test

@drexin
Copy link
Member Author

drexin commented Sep 11, 2020

@swift-ci please nominate

@drexin
Copy link
Member Author

drexin commented Sep 11, 2020

@swift-ci test windows

1 similar comment
@drexin
Copy link
Member Author

drexin commented Sep 11, 2020

@swift-ci test windows

@finagolfin
Copy link
Contributor

How did this change pass the CI in the first place? That seems like a more serious problem. 😜

@DougGregor DougGregor merged commit 865b3b7 into apple:release/5.3 Sep 11, 2020
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks and removed r5.3 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drexin @finagolfin @DougGregor @AnthonyLatsis