Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Move out enum tests into a separate CXXInterop/enum directory #34007

Closed
wants to merge 1 commit into from

Conversation

sureyeaah
Copy link

@sureyeaah sureyeaah commented Sep 21, 2020

#30182 was reverted because of failure on windows. This PR fixes it.

Resolves SR-NNNN.

Currently, tests are scattered throughout multiple directories, making
it difficult to determine what is tested and what is not tested.
With upcoming work on interoperability between Swift and C++
(https://forums.swift.org/t/manifesto-interoperability-between-swift-and-c/33874),
we'd like to rearrange the tests and bring tests covering a single C/C++
feature next to each other.
This PR also adds tests for enabling C++ interop where possible.
@sureyeaah
Copy link
Author

sureyeaah commented Sep 21, 2020

@swift-ci Please test Windows platform

@gribozavr could you run this test for me? Thanks.

@sureyeaah sureyeaah changed the title Move out enum tests into a separate CXXInterop/enum directory [WIP] Move out enum tests into a separate CXXInterop/enum directory Sep 21, 2020
@gribozavr
Copy link
Contributor

@swift-ci Please test Windows platform

@gribozavr
Copy link
Contributor

@swift-ci Please test

@shahmishal
Copy link
Member

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

  • How to change the base branch: (Link)
  • More detail about the branch update: (Link)

@swift-ci
Copy link
Contributor

swift-ci commented Oct 1, 2020

Build failed
Swift Test OS X Platform
Git Sha - a05bb98

@sureyeaah sureyeaah changed the base branch from master to main October 1, 2020 08:42
@sureyeaah sureyeaah closed this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants