[concurrency] Ban associated objects from being set on instances of actor classes. #34136
Conversation
|
@swift-ci test |
|
preset=buildbot,tools=RA,stdlib=RD,test=non_executable |
|
Windows failure is something in lldb, not this. |
|
Build failed |
|
Note to self: add test for meta type as well. |
gottesmm
force-pushed
the
pr-7da9c7145fbd96869d5e73a40a600d6c0e23fa91
branch
5 times, most recently
from
bd59776
to
5a568e3
Compare
|
@atrick I added tests for the other policies. |
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
Build failed |
|
shakes fist at 32 bit |
|
@swift-ci test |
|
Build failed |
|
Build failed |
gottesmm
force-pushed
the
pr-7da9c7145fbd96869d5e73a40a600d6c0e23fa91
branch
from
5a568e3
to
5640f0d
Compare
|
@swift-ci test |
|
preset=buildbot,tools=RA,stdlib=RD,test=non_executable |
|
@swift-ci test windows platform |
|
Build failed |
gottesmm
force-pushed
the
pr-7da9c7145fbd96869d5e73a40a600d6c0e23fa91
branch
from
5640f0d
to
15ddf11
Compare
|
preset=buildbot,tools=RA,stdlib=RD,test=non_executable |
gottesmm
force-pushed
the
pr-7da9c7145fbd96869d5e73a40a600d6c0e23fa91
branch
from
15ddf11
to
28d30d6
Compare
|
@swift-ci test |
|
preset=buildbot,tools=RA,stdlib=RD,test=non_executable |
|
Build failed |
gottesmm
force-pushed
the
pr-7da9c7145fbd96869d5e73a40a600d6c0e23fa91
branch
from
28d30d6
to
a4df48c
Compare
|
@swift-ci test |
|
preset=buildbot,tools=RA,stdlib=RD,test=non_executable |
|
We discovered that the simulator was still failing since the simulator being used is from before the banning feature was in the objc runtime. I put in availability conditions in the Interpreter tests corresponding to the introduction of said feature into libobjc to ensure that we just run any tests on such platforms. |
|
looks like the required bits are slightly different on arm64e for actors. I'll fix that. |
|
I have a fix. I am going to let the full testing finish, then push that test fix, and do another preset test. |
|
Ok! All tests passed except for the non-executable tests. I am going to fix that with a force push and rerun the preset. |
gottesmm
force-pushed
the
pr-7da9c7145fbd96869d5e73a40a600d6c0e23fa91
branch
from
a4df48c
to
8bf3084
Compare
|
preset=buildbot,tools=RA,stdlib=RD,test=non_executable |
gottesmm
force-pushed
the
pr-7da9c7145fbd96869d5e73a40a600d6c0e23fa91
branch
from
8bf3084
to
b61c3c3
Compare
|
Made a typo. |
|
preset=buildbot,tools=RA,stdlib=RD,test=non_executable |
|
@swift-ci test |
gottesmm
force-pushed
the
pr-7da9c7145fbd96869d5e73a40a600d6c0e23fa91
branch
from
b61c3c3
to
7a67cd4
Compare
…ctor classes that do not inherit from NSObject. Associated objects are actively dangerous there because they’re non-isolated actor state, and it’s “new” code wher no backward compatibility concerns that make it more difficult to ban this on other forms of classes. rdar://69769048
gottesmm
force-pushed
the
pr-7da9c7145fbd96869d5e73a40a600d6c0e23fa91
branch
from
7a67cd4
to
91209d3
Compare
|
@swift-ci test |
|
preset=buildbot,tools=RA,stdlib=RD,test=non_executable |
|
Build failed |
|
weird lldb test failure. I hope flaky. |
|
@swift-ci test OS X platform |
|
@swift-ci test |
|
preset=buildbot,tools=RA,stdlib=RD,test=non_executable |
|
Retesting |
|
Build failed |
|
@swift-ci test linux platform |
Associated objects are actively dangerous there because they’re non-isolated
actor state, and it’s “new” code wher no backward compatibility concerns that
make it more difficult to ban this on other forms of classes.
rdar://69769048