Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sema] Decouple ConstraintSystem and TypeChecker headers #34206

Merged
merged 6 commits into from
Oct 7, 2020
Merged

[Sema] Decouple ConstraintSystem and TypeChecker headers #34206

merged 6 commits into from
Oct 7, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Oct 6, 2020

  • NFC: Move implementation of isReadOnlyKeyPathComponent to .cpp
  • Switch typeCheckExpression to use ContextualTypeInfo
  • Move FreeTypeVariableBinding to constraint system header
  • NFC: Move ContextualTypePurpose to constraint system header

@xedin xedin requested a review from CodaFi October 6, 2020 20:43
@xedin
Copy link
Contributor Author

xedin commented Oct 6, 2020

A possible replacement of #34194

@CodaFi
Copy link
Contributor

CodaFi commented Oct 6, 2020

Thank you!

@xedin
Copy link
Contributor Author

xedin commented Oct 6, 2020

@swift-ci please test

@xedin
[TypeChecker] NFC: Include constraint system into TypeChecker header
0b648fb 
Avoids having to include ConstraintSystem.h in TypeCheck*.cpp
files to gain access to ContextualInfo and related classes.
@xedin
Copy link
Contributor Author

xedin commented Oct 6, 2020

@swift-ci please smoke test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 6, 2020

Build failed
Swift Test OS X Platform
Git Sha - f94be56

@swift-ci
Copy link
Contributor

swift-ci commented Oct 6, 2020

Build failed
Swift Test Linux Platform
Git Sha - f94be56

@xedin
Copy link
Contributor Author

xedin commented Oct 7, 2020

@swift-ci please smoke test Windows platform

@xedin xedin merged commit 4175a01 into swiftlang:main Oct 7, 2020
@xedin xedin mentioned this pull request Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodaFi CodaFi CodaFi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xedin @CodaFi @swift-ci