Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build System] Remove tvOS i386 slice from compiler-rt lib #34361

Merged
merged 2 commits into from Oct 20, 2020

Conversation

shahmishal
Copy link
Member

To fix this issue:
ld: building for tvOS, but linking in object file built for tvOS Simulator, file '/tmp/strip.rgKCdx' for architecture i386
fatal error: /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip: internal link edit command failed

rdar://70443440

To fix this issue:
ld: building for tvOS, but linking in object file built for tvOS Simulator, file '/tmp/strip.rgKCdx' for architecture i386
fatal error: /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip: internal link edit command failed

rdar://70443440
@shahmishal
Copy link
Member Author

@swift-ci build toolchain macOS

@shahmishal
Copy link
Member Author

@swift-ci smoke test

@shahmishal shahmishal requested review from hyp and edymtt October 20, 2020 02:00
Copy link
Contributor

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahmishal you want to change the 2x cp above as well. The first could contain the old i386 slices in the non-sim libs (as both libs were in one .a), and the second will contain the i386 slice in the split out sim libs.

@shahmishal
Copy link
Member Author

@swift-ci smoke test

@shahmishal
Copy link
Member Author

@swift-ci build toolchain macOS

@shahmishal
Copy link
Member Author

@swift-ci test windows

@swift-ci
Copy link
Collaborator

macOS Toolchain
Download Toolchain
Git Sha - 73dc49f

Install command
tar -zxf swift-PR-34361-731-osx.tar.gz --directory ~/

@shahmishal shahmishal merged commit 0883836 into main Oct 20, 2020
@shahmishal shahmishal deleted the shahmishal/r70443440 branch October 20, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants