[CMake] Make sure that library evolution is set when compiling overlays. #34371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice, SWIFT_HOST_VARIANT_SDK may be IOS or some other non-OSX Darwin platform. Fixes part of rdar://70156840.
|
cc @porglezomp |
|
@swift-ci please smoke test |
lorentey
reviewed
Oct 21, 2020
Fixes rdar://70156840.
varungandhi-apple
force-pushed
the
vg-cmake-Darwin-library-evolution
branch
from
bd07feb
to
dd4a9f3
Compare
|
@swift-ci please smoke test |
edymtt
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If library evolution is not set, the generated swiftinterface will be incorrect, leading to further errors downstream.
In direct CMake calls to
stdlib/public/Platform/CMakeLists.txt, the variableSWIFT_STDLIB_STABLE_ABIis not initialized.For now, we duplicate the logic inSo we add some initialization instdlib/CMakeLists.txtto make sure that it is initialized properly. We can potentially de-duplicate it later.StandaloneOverlay.cmakewhich is consumed bystdlib/public/Platform/CMakeLists.txt, mimicking the "duplicate" initialization we already have forSWIFT_ENABLE_MODULE_INTERFACES.Fixes rdar://70156840.