Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Fix test cases #34511

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Oct 30, 2020

#34492 conflicts with #34467

@rintaro
Copy link
Member Author

rintaro commented Oct 30, 2020

@swift-ci Please smoke test

1 similar comment
@rintaro
Copy link
Member Author

rintaro commented Oct 30, 2020

@swift-ci Please smoke test

@rintaro rintaro force-pushed the test-fix-after-revert-tupleconformance branch from 8ffca67 to 907fb78 Compare October 30, 2020 05:13
@rintaro
Copy link
Member Author

rintaro commented Oct 30, 2020

@swift-ci Please smoke test

2 similar comments
@rintaro
Copy link
Member Author

rintaro commented Oct 30, 2020

@swift-ci Please smoke test

@davezarzycki
Copy link
Collaborator

@swift-ci Please smoke test

@davezarzycki
Copy link
Collaborator

Is there an ETA for getting this merged? The main branch seems to be broken right now.

@davezarzycki
Copy link
Collaborator

Shouldn't we move validation-test/Sema/type_checker_crashers_fixed/rdar27830834.swift out of the "fixed" directory? Adding not to the test hides the regression.

@tbkka
Copy link
Contributor

tbkka commented Oct 30, 2020

Force-merging to try to get things sane again.

@tbkka tbkka merged commit 147015d into apple:main Oct 30, 2020
@rintaro
Copy link
Member Author

rintaro commented Oct 30, 2020

@davezarzycki This is a crasher test. Since it successfully fails, it's still "fixed".
This failure happened because #34492 was merged during #34505 was testing.

ainu-bot added a commit to google/swift that referenced this pull request Oct 30, 2020
* 'main' of github.com:apple/swift:
  [Test] Fix test cases (apple#34511)
texasmichelle pushed a commit that referenced this pull request Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants