New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Concurrency] Task Local Values #34722

Merged

ktoso merged 7 commits into apple:main from ktoso:wip-tasklocals

Feb 14, 2021

Member

ktoso commented Nov 13, 2020 •

edited

Initial implementation for Task Local Values (pitch thread)

use the task local allocator
remove the iostream usage
add throwing overloads
skip tasks during lookups which do not "contribute" any values; this should naturally fall out of the linking model
attempt implementation without having to spawn child tasks for changing values; we can do this by treating the links as a stack on which we add and pop bindings as we enter scopes; a scope must only remember how many values it has bound and then we can pop them as we exit

rdar://67036782

ktoso marked this pull request as draft

November 13, 2020 11:04

ktoso changed the title ~~[Concurrency] Task Local Values experiments~~ [Discussion][Concurrency] Task Local Values experiments

ktoso requested a review from DougGregor

November 13, 2020 11:06

ktoso force-pushed the wip-tasklocals branch from 3022a9d to 3f12dab Compare

December 16, 2020 01:00

ktoso changed the title ~~[Discussion][Concurrency] Task Local Values experiments~~ [Discussion][Concurrency] Task Local Values

ktoso force-pushed the wip-tasklocals branch from 3f12dab to 7342b03 Compare

December 16, 2020 04:45

ktoso commented

View reviewed changes

test/Concurrency/Runtime/basic_task_local.swift Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

include/swift/ABI/Task.h Outdated Show resolved Hide resolved

ktoso commented

View reviewed changes

include/swift/ABI/Task.h Outdated Show resolved Hide resolved

ktoso changed the title ~~[Discussion][Concurrency] Task Local Values~~ [WIP][Concurrency] Task Local Values

ktoso commented

View reviewed changes

include/swift/ABI/Task.h Outdated Show resolved Hide resolved

DougGregor reviewed

View reviewed changes

include/swift/ABI/Task.h Outdated Show resolved Hide resolved

include/swift/ABI/Task.h Outdated Show resolved Hide resolved

include/swift/ABI/Task.h Outdated Show resolved Hide resolved

include/swift/ABI/Task.h Outdated Show resolved Hide resolved

include/swift/Runtime/Concurrency.h Outdated Show resolved Hide resolved

stdlib/public/Concurrency/TaskLocal.swift Outdated Show resolved Hide resolved

ktoso force-pushed the wip-tasklocals branch from 7342b03 to 3dd9cd0 Compare

December 16, 2020 13:36

ktoso commented

View reviewed changes

include/swift/ABI/MetadataValues.h Outdated Show resolved Hide resolved

ktoso force-pushed the wip-tasklocals branch from 3dd9cd0 to 3d59bb5 Compare

December 17, 2020 13:16

ktoso commented

View reviewed changes

include/swift/ABI/Task.h Outdated Show resolved Hide resolved

ktoso force-pushed the wip-tasklocals branch from 3d59bb5 to a37e740 Compare

December 17, 2020 13:25

Member Author

ktoso commented Dec 17, 2020

@swift-ci please smoke test

ktoso force-pushed the wip-tasklocals branch from a37e740 to 6b3ba1d Compare

December 18, 2020 10:09

ktoso changed the title ~~[WIP][Concurrency] Task Local Values~~ [Concurrency] Task Local Values

Member Author

ktoso commented Dec 21, 2020

This is now PoC complete, however creates many child tasks and does not apply the optimizations for skipping through empty tasks; I'll implement this shortly.

ktoso force-pushed the wip-tasklocals branch 2 times, most recently from 87e2fde to f86f6a5 Compare

December 22, 2020 08:19

ktoso marked this pull request as ready for review

December 28, 2020 04:03

ktoso force-pushed the wip-tasklocals branch from f86f6a5 to c060632 Compare

January 5, 2021 23:47

This was referenced Jan 6, 2021

[Concurrency] Task Local Values apple/swift-evolution#1245

Merged

Revert "Salvage debug info for function arguments in coro-split funclets." apple/llvm-project#2282

Closed

Member Author

ktoso commented Jan 7, 2021

@swift-ci please smoke test linux

ktoso force-pushed the wip-tasklocals branch 2 times, most recently from 2562391 to f5d6082 Compare

January 7, 2021 14:13

Member Author

ktoso commented Jan 8, 2021

@swift-ci please smoke test linux

Member Author

ktoso commented Jan 13, 2021

Ok with the LLVM fix merged this should work now...?

Member Author

ktoso commented Jan 13, 2021

@swift-ci please smoke test

ktoso force-pushed the wip-tasklocals branch from f5d6082 to 0ee7f84 Compare

February 10, 2021 10:59

Member Author

ktoso commented Feb 10, 2021

@swift-ci please smoke test

ktoso force-pushed the wip-tasklocals branch 5 times, most recently from 190d743 to 2799b72 Compare

February 11, 2021 03:42

Member Author

ktoso commented Feb 11, 2021

@swift-ci please smoke test

Member Author

ktoso commented Feb 11, 2021

LLVM fixed again 🥳

This should be good to go if tests pass, will pitch and address all upcoming feedback as we get more experience with using those in practice.

ktoso added 3 commits

February 12, 2021 16:40


          Merge branch 'main' of github.com:apple/swift into main

9d010cc


          Merge branch 'wip-tasks-rev3' into main

0580cb5


          Merge branch 'main' of github.com:apple/swift into main

aaa0dfe

ktoso force-pushed the wip-tasklocals branch from 2799b72 to e98271f Compare

February 12, 2021 10:31

Member Author

ktoso commented Feb 12, 2021

@swift-ci please smoke test

ktoso added 3 commits

February 13, 2021 10:23


          Merge branch 'main' of github.com:apple/swift into main

e9ff5fd


          [Concurrency] Initial Task Local Values implementation


          [Concurrency] TaskLocals lookup "skip" optimization

b811b12

ktoso force-pushed the wip-tasklocals branch from e98271f to 2da1461 Compare

February 13, 2021 02:51

Member Author

ktoso commented Feb 13, 2021

@swift-ci please smoke test and merge

ktoso force-pushed the wip-tasklocals branch from 2da1461 to 7c295f9 Compare

February 13, 2021 11:04


          [Concurrency] TaskLocals allow configuring inheritance: never

d2bd6ab

ktoso force-pushed the wip-tasklocals branch from 7c295f9 to d2bd6ab Compare

February 13, 2021 11:09

ktoso mentioned this pull request

[Concurrency] Reimplement Task.Group with accordance to Pitch #3 #35874

Merged

Member Author

ktoso commented Feb 14, 2021

@swift-ci please smoke test

Member Author

ktoso commented Feb 14, 2021

@swift-ci please test windows

ktoso merged commit e6af501 into apple:main

ktoso deleted the wip-tasklocals branch

February 14, 2021 08:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment