[concurrency] allow type initializers to be 'async' #35398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
force-pushed
the
async-initializers
branch
3 times, most recently
from
968da1e
to
755bbff
Compare
|
@swift-ci please test |
|
Build failed |
DougGregor
approved these changes
Apr 13, 2021
DougGregor
reviewed
Apr 13, 2021
kavon
force-pushed
the
async-initializers
branch
4 times, most recently
from
42f4795
to
b818676
Compare
|
@swift-ci Please smoke test and merge |
There's a basic prolog emission function, used by value and class constructors, etc, and then there's the full-blown one for functions and closures, which uses the basic version.
implicit calls to an async super.init are not allowed
types correctly hop to the right global-actor in their prolog.
new phrasing in the error messages to match up with other phrasing used in messages.
kavon
force-pushed
the
async-initializers
branch
from
b818676
to
4a32b06
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier in the design of async/await, we disallowed async initializers for nominal types. There is no fundamental reason for the restriction and it was decided that async initializers would actually be useful (to allow initializers to invoke async functions, for example), and so they appear in the now accepted async/await proposal.
This PR fills in this missing part of the proposal, by allowing initializers to be async.
Resolves rdar://71049563
TODO: