A Fond Farewell to Source-Range-Based Dependencies #35425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
⛵ |
davidungar
reviewed
Jan 14, 2021
There was a problem hiding this comment.
There are some potentially-worthwhile frameworks in here. Maybe it would be good to make a branch in the apple repo of the last version of main before removing this stuff? Or a tag, or something... Just to make it a little easier to find things in the future if we want them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was certainly a fun experiment. Ultimately, we saw greater wins from the dynamic duo of type body fingerprints and private dependencies.
Drop all of the infrastructure for this feature from the Driver and Frontend.