Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4][Runtime] Scan backwards within conformance sections when scanSectionsBackwards is true. #35491

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Jan 19, 2021

Cherry-pick #35489 to 5.4.

This more closely matches the previous behavior.

rdar://73362732

…ctionsBackwards is true.

This more closely matches the previous behavior.

rdar://73362732
(cherry picked from commit 32d1c22)
@mikeash mikeash requested a review from a team as a code owner January 19, 2021 21:20
@mikeash
Copy link
Contributor Author

mikeash commented Jan 19, 2021

@swift-ci please test

Copy link
Contributor

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward enough.

@swift-ci
Copy link
Collaborator

Build failed
Swift Test OS X Platform
Git Sha - e674980

@mikeash
Copy link
Contributor Author

mikeash commented Jan 19, 2021

@swift-ci please test os x platform

@swift-ci
Copy link
Collaborator

Build failed
Swift Test OS X Platform
Git Sha - e674980

@mikeash
Copy link
Contributor Author

mikeash commented Jan 19, 2021

@swift-ci please test os x platform

@mikeash
Copy link
Contributor Author

mikeash commented Jan 20, 2021

@swift-ci please test Windows platform

1 similar comment
@mikeash
Copy link
Contributor Author

mikeash commented Jan 20, 2021

@swift-ci please test Windows platform

@mikeash mikeash merged commit 0d0f08c into apple:release/5.4 Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants