[Testing] Unbreak unified build testing #35513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test assumes an Apple platform but for reasons unknown, the Linux bots (wrongly?) consider this test to be unsupported.
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test macos |
|
Hmmmm...... There are some strange things going on here.
|
|
@swift-ci Please test Linux |
CodaFi
reviewed
Jan 20, 2021
| @@ -8,6 +8,7 @@ | |||
|
|
|||
| // REQUIRES: reflection_test_support | |||
| // REQUIRES: executable_test | |||
| // REQUIRES: OS=macosx || OS=tvos || OS=watchos || OS=ios | |||
There was a problem hiding this comment.
Suggested change
| // REQUIRES: OS=macosx || OS=tvos || OS=watchos || OS=ios | |
| // REQUIRES: VENDOR=apple |
There was a problem hiding this comment.
VENDOR? I'm not at my computer. What does that even mean for Swift's test suite? In Apple's history, they've vended various non-Darwin OSes, so that suggestion feels horribly imprecise
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test assumes an Apple platform but for reasons unknown, the Linux bots (wrongly?) consider this test to be unsupported.