Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-script] Add swift-disable-dead-stripping option for disabling dead stripping #35538

Merged

Conversation

mininny
Copy link
Contributor

@mininny mininny commented Jan 21, 2021

With the new build script flag --swift-disable-dead-stripping, swift frontend will be built without dead stripping which can improve debugging.

Resolves SR-13631.

@mininny mininny force-pushed the disable-dead-stripping-option branch from 16e3d8c to ecb65ba Compare January 22, 2021 14:51
@mininny mininny force-pushed the disable-dead-stripping-option branch from ecb65ba to b042682 Compare January 22, 2021 14:56
@varungandhi-apple
Copy link
Contributor

@swift-ci smoke test and merge

@varungandhi-apple
Copy link
Contributor

Couple of Python test failures:

******************** TEST 'Swift(macosx-x86_64) :: Python/build_swift.swift' FAILED ********************
Script:
--
: 'RUN: at line 10';   /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Users/buildnode/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/utils/build_swift/run_tests.py
--
Exit Code: 1

Command Output (stderr):
--
.....................................................................................................................................................................................................................................................................................................................F.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
======================================================================
FAIL: test_expected_options_exhaustive (tests.build_swift.test_driver_arguments.TestDriverArgumentParser)
Test that we are exhaustively testing all options accepted by the
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/buildnode/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/utils/build_swift/tests/build_swift/test_driver_arguments.py", line 418, in test_expected_options_exhaustive
    self.fail('non-exhaustive expected options, missing: {}'
AssertionError: non-exhaustive expected options, missing: {'--swift-disable-dead-stripping'}

----------------------------------------------------------------------
Ran 1039 tests in 33.278s

FAILED (failures=1)

--

********************
PASS: Swift(macosx-x86_64) :: Evolution/test_enum_add_cases_trap.swift (7486 of 14077)
PASS: Swift(macosx-x86_64) :: Evolution/test_conformance_reference.swift (7487 of 14077)
PASS: Swift(macosx-x86_64) :: Evolution/test_enum_add_cases.swift (7488 of 14077)
FAIL: Swift(macosx-x86_64) :: Python/python_lint.swift (7489 of 14077)
******************** TEST 'Swift(macosx-x86_64) :: Python/python_lint.swift' FAILED ********************
Script:
--
: 'RUN: at line 8';   /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Users/buildnode/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/utils/python_lint.py
--
Exit Code: 1

Command Output (stdout):
--
./utils/build-script:603:1: W293 blank line contains whitespace
./utils/build_swift/build_swift/driver_arguments.py:337:1: W293 blank line contains whitespace

--

********************

@mininny
Copy link
Contributor Author

mininny commented Jan 28, 2021

Couple of Python test failures:

******************** TEST 'Swift(macosx-x86_64) :: Python/build_swift.swift' FAILED ********************
Script:
--
: 'RUN: at line 10';   /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Users/buildnode/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/utils/build_swift/run_tests.py
--
Exit Code: 1

Command Output (stderr):
--
.....................................................................................................................................................................................................................................................................................................................F.........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
======================================================================
FAIL: test_expected_options_exhaustive (tests.build_swift.test_driver_arguments.TestDriverArgumentParser)
Test that we are exhaustively testing all options accepted by the
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/buildnode/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/utils/build_swift/tests/build_swift/test_driver_arguments.py", line 418, in test_expected_options_exhaustive
    self.fail('non-exhaustive expected options, missing: {}'
AssertionError: non-exhaustive expected options, missing: {'--swift-disable-dead-stripping'}

----------------------------------------------------------------------
Ran 1039 tests in 33.278s

FAILED (failures=1)

--

********************
PASS: Swift(macosx-x86_64) :: Evolution/test_enum_add_cases_trap.swift (7486 of 14077)
PASS: Swift(macosx-x86_64) :: Evolution/test_conformance_reference.swift (7487 of 14077)
PASS: Swift(macosx-x86_64) :: Evolution/test_enum_add_cases.swift (7488 of 14077)
FAIL: Swift(macosx-x86_64) :: Python/python_lint.swift (7489 of 14077)
******************** TEST 'Swift(macosx-x86_64) :: Python/python_lint.swift' FAILED ********************
Script:
--
: 'RUN: at line 8';   /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Users/buildnode/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/utils/python_lint.py
--
Exit Code: 1

Command Output (stdout):
--
./utils/build-script:603:1: W293 blank line contains whitespace
./utils/build_swift/build_swift/driver_arguments.py:337:1: W293 blank line contains whitespace

--

********************

Thanks for letting me know! I tried to fix it by looking around the code, but I couldn't test it with validation test on my MacBook(it keeps getting stuck). Can you please try run the test again? :)

@varungandhi-apple
Copy link
Contributor

Sure. Btw, one way your should be able to run them is by something like:

$ utils/build-script [... other flags ...] --validation-test
# Hit Ctrl-C once it starts executing the validation tests
# This should create a validation-test-macosx-x86_64 directory
/path/to/lit.py -s -vv /path/to/swift-macosx-x86_64/validation-test-macosx-x86_64 --filter "Python"

@swift-ci smoke test

@mininny mininny force-pushed the disable-dead-stripping-option branch from 7cb4fcf to 16e635b Compare January 31, 2021 03:51
@mininny
Copy link
Contributor Author

mininny commented Jan 31, 2021

Sure. Btw, one way your should be able to run them is by something like:

$ utils/build-script [... other flags ...] --validation-test
# Hit Ctrl-C once it starts executing the validation tests
# This should create a validation-test-macosx-x86_64 directory
/path/to/lit.py -s -vv /path/to/swift-macosx-x86_64/validation-test-macosx-x86_64 --filter "Python"

@swift-ci smoke test

Thanks! :) Can you please trigger the test again?

@varungandhi-apple
Copy link
Contributor

@swift-ci smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants