Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ast] Enable the ASTVerifier behind the enable-ast-verifier flag in no-asserts builds. #35587

Merged

Commits on Jan 25, 2021

  1. [ast] Enable the ASTVerifier behind the enable-ast-verifier flag in n…

    …o-asserts builds.
    
    This follows the design of how we handled this with
    sil-verify-all. Specifically, the default behavior is to run only in asserts
    builds, but one can use the two flags: enable-ast-verifier and
    disable-ast-verifier to override the default behavior.
    
    The reason why this is interesting is that this means that when compiling
    normally, we will not run the verifier, so we won't have a perf hit. But we can
    now ask the user to run with this flag (or in a future maybe a re-run in the
    driver would do this for them), saving us time when screening bugs by avoiding
    the need to build an asserts compiler to triage if the ASTVerifier would catch
    the bug.
    gottesmm committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    1de2d3f View commit details
    Browse the repository at this point in the history