Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OutputStream to OutputStreamable [SE-0086] #3576

Merged
merged 2 commits into from
Jul 19, 2016

Conversation

parkera
Copy link
Contributor

@parkera parkera commented Jul 18, 2016

What's in this pull request?

Per the accepted SE-0086, rename the standard library OutputStream type to OutputStreamable. NSOutputStream will become OutputStream in a different commit.

Resolved bug number

rdar://27355220


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@parkera
Copy link
Contributor Author

parkera commented Jul 18, 2016

@swift-ci please test

@parkera
Copy link
Contributor Author

parkera commented Jul 18, 2016

cc @dabrahams @gribozavr

@dabrahams
Copy link
Contributor

I’m sorry, I didn’t expect to find stdlib API changes in a proposal with that title, so I didn’t review this, and nobody brought it to my attention. OutputStreamable is not the right name for this protocol. It represents things into which bits of text can be streamed, not things that can themselves be streamed. TextOutputStream would be an acceptable name.

@xwu
Copy link
Collaborator

xwu commented Jul 18, 2016

How about OutputStreaming or the delightfully uncreative OutputStreamProtocol?

@dabrahams
Copy link
Contributor

on Mon Jul 18 2016, Xiaodi Wu <notifications-AT-github.com> wrote:

How about OutputStreaming or the delightfully uncreative OutputStreamProtocol?

To me these seem much weaker than TextOutputStream; the first is
ambiguous about whether the conforming type is the stream or the
to-be-streamed and both leave out the Text part which is a very specific
constraint of this protocol.

@parkera
Copy link
Contributor Author

parkera commented Jul 18, 2016

Fine, TextOutputStream. Looks like we need a PR for swiftpm as well.

@parkera
Copy link
Contributor Author

parkera commented Jul 19, 2016

kicking off tests again; swiftpm will fail but at least we'll know the rest is right.

@parkera
Copy link
Contributor Author

parkera commented Jul 19, 2016

@swift-ci please test

@parkera
Copy link
Contributor Author

parkera commented Jul 19, 2016

I'm going to add a temporary typealias to avoid the lock-step build dependencies between projects.

@parkera
Copy link
Contributor Author

parkera commented Jul 19, 2016

@swift-ci Please test and merge

@parkera
Copy link
Contributor Author

parkera commented Jul 19, 2016

We're going to go ahead and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants