[docs] Add warning that sccache isn't caching any commands since version 0.13.4 #35777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
docs/HowToGuides/GettingStarted.md
Outdated
| @@ -137,6 +137,7 @@ Double-check that running `pwd` prints a path ending with `swift`. | |||
| ```sh | |||
| brew install cmake ninja sccache | |||
| ``` | |||
| ⚠️ Since version 0.13.4, `sccache` no longer caches compile commands issued by `build-script` because of [this](https://github.com/mozilla/sccache/pull/898) change and since `build-script` adds the `-arch x86_64` argument twice. | |||
There was a problem hiding this comment.
Should this be version 0.2.14 instead of 0.13.4? (Releases)
There was a problem hiding this comment.
Of course. Thanks for checking.
ahoppen
force-pushed
the
sccache-not-working
branch
from
1df9993
to
0a76294
Compare
|
@swift-ci Please smoke test |
varungandhi-apple
approved these changes
Feb 5, 2021
docs/HowToGuides/GettingStarted.md
Outdated
| @@ -137,6 +137,7 @@ Double-check that running `pwd` prints a path ending with `swift`. | |||
| ```sh | |||
| brew install cmake ninja sccache | |||
| ``` | |||
| ⚠️ Since version 0.2.14, `sccache` no longer caches compile commands issued by `build-script` because of [this](https://github.com/mozilla/sccache/pull/898) change and since `build-script` adds the `-arch x86_64` argument twice. | |||
There was a problem hiding this comment.
I just realized, this is in the macOS section, but this problem almost certainly affects Linux too. It may make more sense to have this warning be displayed immediately at the beginning of Installing dependencies section. Say something like:
⚠️ Since version 0.2.14, `sccache` no longer caches compile commands issued by `build-script` because of [sccache PR 898](https://github.com/mozilla/sccache/pull/898), since `build-script` adds the `-arch x86_64` argument twice. The instructions below may install `sccache` 0.2.14 or newer. You may want to instead download and install an older release from their [Releases page](https://github.com/mozilla/sccache/releases) until this issue is resolved.
ahoppen
force-pushed
the
sccache-not-working
branch
from
0a76294
to
9874152
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.