Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SR-14282] Compiler crash in DictionaryTrapsObjC.swift #36426

Merged
merged 1 commit into from Mar 14, 2021
Merged

[SR-14282] Compiler crash in DictionaryTrapsObjC.swift #36426

merged 1 commit into from Mar 14, 2021

Conversation

benrimmington
Copy link
Collaborator

@benrimmington benrimmington commented Mar 12, 2021 •
edited

The bug reported in SR-14282 is no longer reproducible.

rdar://problem/74877200

@benrimmington
Copy link
Collaborator Author

@swift-ci Please smoke test

@benrimmington
Copy link
Collaborator Author

@swift-ci Please test macOS platform

@swift-ci
Copy link
Collaborator

Build failed
Swift Test OS X Platform
Git Sha - cbba504

@benrimmington
Copy link
Collaborator Author 

PASS: Swift(macosx-x86_64) :: stdlib/DictionaryTrapsObjC.swift (879 of 14345)
PASS: Swift(iphonesimulator-x86_64) :: stdlib/DictionaryTrapsObjC.swift (876 of 14345)
PASS: Swift(watchsimulator-i386) :: stdlib/DictionaryTrapsObjC.swift (875 of 14345)

Failed Tests (1):
  Swift(watchsimulator-i386) :: IRGen/async/hop_to_executor.sil

@benrimmington
Copy link
Collaborator Author

@swift-ci Please smoke test macOS platform

@benrimmington benrimmington marked this pull request as ready for review March 13, 2021 07:14
eeckstein
eeckstein approved these changes Mar 14, 2021
View reviewed changes
Copy link
Member

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@eeckstein eeckstein merged commit 5acd5e6 into apple:main Mar 14, 2021
@benrimmington benrimmington deleted the sr-14282 branch March 14, 2021 22:35
@benrimmington benrimmington mentioned this pull request Mar 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benrimmington @swift-ci @eeckstein