Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing _Concurrency dependency to the Dispatch overlay #37186

Merged
merged 1 commit into from
May 11, 2021
Merged

Add missing _Concurrency dependency to the Dispatch overlay #37186

merged 1 commit into from
May 11, 2021

Conversation

Catfish-Man
Copy link
Contributor

@Catfish-Man Catfish-Man commented Apr 30, 2021 •
edited by DougGregor
Loading

Fixes rdar://77237074

@Catfish-Man Catfish-Man self-assigned this Apr 30, 2021
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 477b4a8008c7418afaf17fe334b361f4e6b97304

@swift-ci
Copy link
Contributor

swift-ci commented May 1, 2021

Build failed
Swift Test OS X Platform
Git Sha - 477b4a8008c7418afaf17fe334b361f4e6b97304

@DougGregor
Copy link
Member

@swift-ci please smoke test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@DougGregor
Copy link
Member

Apparently, that last tweak didn't work:

16:37:47 ld: library not found for -lswift_Concurrency{SWIFT_PRIMARY_VARIANT_SUFFIX}
16:37:47 clang-10: error: linker command failed with exit code 1 (use -v to see invocation)

@DougGregor
Copy link
Member

@swift-ci please test

@DougGregor
Copy link
Member

Trying the fix that I expect will work

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2021

Build failed
Swift Test OS X Platform
Git Sha - 8c95519c50ba173ddc710ac46bed5b7270ad2514

@Catfish-Man
Copy link
Contributor Author

How does this work locally then? Baffling

@DougGregor
Copy link
Member

I AM SO CONFUSED

@shahmishal
Copy link
Member

@swift-ci please test macOS

@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2021

Build failed
Swift Test OS X Platform
Git Sha - 8c95519c50ba173ddc710ac46bed5b7270ad2514

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented May 5, 2021

Build failed
Swift Test Linux Platform
Git Sha - 3f4ab4fc3a3eec521d4e4aacab8dc3151f870d39

@swift-ci
Copy link
Contributor

swift-ci commented May 6, 2021

Build failed
Swift Test OS X Platform
Git Sha - 3f4ab4fc3a3eec521d4e4aacab8dc3151f870d39

@ktoso ktoso mentioned this pull request May 6, 2021
Merged
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented May 6, 2021

Build failed
Swift Test OS X Platform
Git Sha - 62e22acf00e00d165bd70ee83dbf6c7521d4f99c

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

2 similar comments
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented May 7, 2021

Build failed
Swift Test Linux Platform
Git Sha - 5862e62c574641502588d5ecdf3f8c7953d8240f

@swift-ci
Copy link
Contributor

swift-ci commented May 7, 2021

Build failed
Swift Test OS X Platform
Git Sha - 5862e62c574641502588d5ecdf3f8c7953d8240f

@Catfish-Man
Copy link
Contributor Author

preset=stdlib_S_standalone_minimal_macho_x86_64,build,test
@swift-ci please test with toolchain and preset

@swift-ci
Copy link
Contributor

swift-ci commented May 7, 2021

Build failed
Swift Test OS X Platform
Git Sha - 22350cf34766608fde2f8dcc5fe20df1675a8356

@edymtt
Copy link
Contributor

edymtt commented May 7, 2021

@swift-ci please test

@edymtt
Copy link
Contributor

edymtt commented May 7, 2021

@swift-ci please build toolchain

@swift-ci
Copy link
Contributor

swift-ci commented May 7, 2021

Linux Toolchain (Ubuntu 16.04)
Download Toolchain
Git Sha - 22350cf34766608fde2f8dcc5fe20df1675a8356

Install command
tar zxf swift-PR-37186-589-ubuntu16.04.tar.gz
More info

@swift-ci
Copy link
Contributor

swift-ci commented May 7, 2021

Build failed
Swift Test OS X Platform
Git Sha - 22350cf34766608fde2f8dcc5fe20df1675a8356

@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test

@edymtt edymtt mentioned this pull request May 10, 2021
Closed
@edymtt
Copy link
Contributor

edymtt commented May 10, 2021

@swift-ci please smoke test macOS

@edymtt
Copy link
Contributor

edymtt commented May 10, 2021

@swift-ci please build toolchain macOS

@edymtt
Copy link
Contributor

edymtt commented May 10, 2021

@swift-ci please smoke test Linux

@edymtt
Copy link
Contributor

edymtt commented May 10, 2021 •
edited
Loading

@swift-ci please smoke test macOS

edit: apologies for rescheduling this, confused the failing full test with the smoke test one...

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 22350cf34766608fde2f8dcc5fe20df1675a8356

Install command
tar -zxf swift-PR-37186-978-osx.tar.gz --directory ~/

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit 7ee2a5c into swiftlang:main May 11, 2021
@DougGregor DougGregor mentioned this pull request May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees

@Catfish-Man Catfish-Man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Catfish-Man @swift-ci @DougGregor @shahmishal @edymtt