[CodeCompletion] Suggest typealias on protocols #38054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
reviewed
Jun 30, 2021
| @@ -156,6 +156,12 @@ static bool isMemberDeclAppliedInternal(const DeclContext *DC, Type BaseTy, | |||
| GenericSignature genericSig = genericDecl->getGenericSignature(); | |||
| if (!genericSig) | |||
| return true; | |||
| if (isa<TypeAliasDecl>(VD) && BaseTy->is<ProtocolType>()) { | |||
There was a problem hiding this comment.
Could we do this before line 153, before getting the generic signature?
There was a problem hiding this comment.
Good catch, makes sense as it’s cheaper to check. Moved it up
| // RUN: %target-swift-ide-test -batch-code-completion -source-filename %s -filecheck %raw-FileCheck -completion-output-dir %t | ||
|
|
||
| protocol MyProto { | ||
| typealias Content = Int |
There was a problem hiding this comment.
Can you add a typealias with generic arguments? e.g. typealias Storage<T> = Array<T>. I don't this your change affects this case, but still.
There was a problem hiding this comment.
Added a test case. Seems to not be an issue.
Previously, we were never suggesting typealias declarations when completing on a protocol type. Fixes rdar://78780638 [SR-14688]
ahoppen
force-pushed
the
pr/suggest-typealias-on-protocols
branch
from
3a17aba
to
088a331
Compare
|
@swift-ci Please smoke test |
rintaro
approved these changes
Jul 1, 2021
|
Windows failures is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were never suggesting typealias declarations when completing on a protocol type.
Fixes rdar://78780638 [SR-14688]