[Concurrency] SR-15309: Fix instance task.isCancelled impl to use _task #39710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
ktoso
added
the
concurrency
|
Silly unrelated failure on mac |
|
@swift-ci please smoke test macOS |
rjmccall
approved these changes
Oct 13, 2021
DougGregor
pushed a commit
to DougGregor/swift
that referenced
this pull request
Oct 13, 2021
…sk (apple#39710) (cherry picked from commit 737962e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instance (not static) version of
isCancelledwas using the current task, rather than the_taskof the Task it was defined in...Resolves SR-15309
Resolves rdar://84146091