AST: Make sure malscoped extensions get their extended nominal computed #40082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
slavapestov
approved these changes
Nov 8, 2021
| @@ -37,6 +37,19 @@ protocol NestingTest5 { | |||
| func nestingTest6() { | |||
| extension Foo {} // expected-error {{declaration is only valid at file scope}} | |||
| } | |||
| extension Array { | |||
There was a problem hiding this comment.
Might be better to put the original test case in validation-test/compiler_crashers_2_fixed/sr15447.swift.
There was a problem hiding this comment.
Let's keep this one as well to spot regressions or improvements in diagnostics.
|
@swift-ci please smoke test |
AnthonyLatsis
force-pushed
the
invalid-ext-bind
branch
from
b5bf9b1
to
2bbe1af
Compare
|
@swift-ci please smoke test |
AnthonyLatsis
force-pushed
the
invalid-ext-bind
branch
from
2bbe1af
to
5215fe5
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extension nested inside a closure would get its extended nominal queried by name lookup before it got explicitly computed by the declaration checker, causing it to fall out of sync with the extended type. To prevent this from happening, amend getExtendedNominal() to always compute itself for extensions with an invalid parent context.
Resolves SR-15447