Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noescape by default: deprecate @noescape and @autoclosure(escaping) #4031

Merged
merged 8 commits into from Aug 5, 2016

Conversation

milseman
Copy link
Contributor

@milseman milseman commented Aug 5, 2016

What's in this pull request?

Support the @autoclosure @escaping syntax, deprecate @NoEscape and @autoclosure(escaping). Fixits and tests included.

Resolved bug number: (SR-)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@milseman
Copy link
Contributor Author

milseman commented Aug 5, 2016

@swift-ci please test

@milseman
Copy link
Contributor Author

milseman commented Aug 5, 2016

@swift-ci please test


* [SE-103](https://github.com/apple/swift-evolution/blob/master/proposals/0103-make-noescape-default.md)

Closure parameters are non-escaping by default, rather than explicitly being
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits of code in the changelog should be surrounded by backticks (`)

@tkremenek
Copy link
Member

@swift-ci test linux

4 similar comments
@tkremenek
Copy link
Member

@swift-ci test linux

@tkremenek
Copy link
Member

@swift-ci test linux

@tkremenek
Copy link
Member

@swift-ci test linux

@tkremenek
Copy link
Member

@swift-ci test linux

@milseman
Copy link
Contributor Author

milseman commented Aug 5, 2016

@swift-ci please test

@milseman
Copy link
Contributor Author

milseman commented Aug 5, 2016

Failure unrelated:
Serialization/failed-clang-module.swift
/Users/buildnode/jenkins/workspace/swift-PR-osx/buildbot_incremental/swift-macosx-x86_64/test-iphonesimulator-i386/Serialization/Output/failed-clang-module.swift.tmp/MixModA.framework/Modules/module.modulemap:3:10: error: inferred submodules require a module with an umbrella
module * { export * }
^

Which is a new test file that's been problematic:

@milseman milseman merged commit 045bc16 into apple:master Aug 5, 2016
@slavapestov
Copy link
Member

@milseman Thanks for taking the time to do the changes, the patch looks much cleaner now!

@milseman milseman deleted the noescape_by_default branch September 29, 2016 18:12
kateinoigakukun pushed a commit that referenced this pull request Aug 31, 2022
[pull] swiftwasm from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants