Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORTANT] Add missing year and Apple INC. in license #40545

Closed
wants to merge 3 commits into from
Closed

[IMPORTANT] Add missing year and Apple INC. in license #40545

wants to merge 3 commits into from

Conversation

KittyBorgX
Copy link

The LICENSE in this repository had a missing Year and org. This PR adds the relavant date and Apple INC. org to the license

@KittyBorgX KittyBorgX changed the title Add missing year and Apple INC. in license [IMPORTANT] Add missing year and Apple INC. in license Dec 14, 2021
@KittyBorgX
Copy link
Author

KittyBorgX commented Dec 15, 2021

This is my first time contributing! I'm requesting a rewiew from one of the Owners!

This mention is according to the section mentioned in : https://github.com/apple/swift/blob/main/docs/HowToGuides/FirstPullRequest.md

@DougGregor

LICENSE.txt Outdated Show resolved Hide resolved
@Kyle-Ye
Copy link
Collaborator

Kyle-Ye commented Dec 15, 2021

LGTM.

One more thing is that I don't know how Apple thinks the name: Should it be "Apple INC.", "Apple, Inc" or "APPLE INC.".

@KittyBorgX
Copy link
Author

@Kyle-Ye Judging the contents of this file :
https://github.com/apple/password-manager-resources/blob/main/LICENSE.md

Im guessing it would be Apple Inc. or Apple INC.

@xwu
Copy link
Collaborator

xwu commented Dec 28, 2021

Hi @KittyBorgX, thanks for looking to contribute.

What you've edited is an appendix of the Apache license itself, which should not be edited. The appendix provides information for readers about how to apply the license to their own work, and it's not supposed to have Apple's name here.

See also:

#123
#124
#1444
#2438
#34933

@xwu xwu closed this Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants