Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix propagation of SWIFT_ENABLE_REFLECTION from CMake into lit.cfg and re-enable 'REQUIRES: reflection' tests #40720

Merged
merged 1 commit into from Jan 5, 2022
Merged

Fix propagation of SWIFT_ENABLE_REFLECTION from CMake into lit.cfg and re-enable 'REQUIRES: reflection' tests #40720

merged 1 commit into from Jan 5, 2022

Conversation

kubamracek
Copy link
Contributor

@kubamracek kubamracek commented Jan 2, 2022 •
edited

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 2, 2022

Build failed
Swift Test Linux Platform
Git Sha - 4a502e7f5fea1414d65162d03747e5e4f90adf9b

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 2, 2022

Build failed
Swift Test OS X Platform
Git Sha - 4a502e7f5fea1414d65162d03747e5e4f90adf9b

@kubamracek kubamracek force-pushed the fix-and-re-enable-reflection-tests branch from 4a502e7 to 0a21b06 Compare January 2, 2022 16:11
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 2, 2022

Build failed
Swift Test Linux Platform
Git Sha - 0a21b06

@kubamracek
Copy link
Contributor Author

@swift-ci please test Linux platform

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 2, 2022

Build failed
Swift Test Linux Platform
Git Sha - 0a21b06

@compnerd
Copy link
Collaborator

compnerd commented Jan 3, 2022

@kubamracek - the windows builds need to be fixed by @eeckstein, there was some breakage that was introduced by changes to the libswift work.

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Collaborator

swift-ci commented Jan 4, 2022

Build failed
Swift Test OS X Platform
Git Sha - 0a21b06

@kubamracek
Copy link
Contributor Author

@swift-ci please test macOS platform

@kubamracek kubamracek merged commit 1ad13c0 into apple:main Jan 5, 2022
@kubamracek kubamracek deleted the fix-and-re-enable-reflection-tests branch January 5, 2022 03:31
@benrimmington
Copy link
Collaborator

I've added a comment to SR-15661 (the validation tests are still unsupported).

@finagolfin finagolfin mentioned this pull request Jan 5, 2022
Merged
@kubamracek kubamracek mannequin mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kubamracek @swift-ci @compnerd @benrimmington