RequirementMachine: More fixes for property map induced rules #40752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andled in the property map
slavapestov
force-pushed
the
rqm-more-property-map-rewrite-loops
branch
from
ce807c6
to
e57d6ea
Compare
…ion domain When minimizing a generic signature, we only care about loops where the basepoint is a generic parameter symbol. When minimizing protocol requirement signatures in a connected component, we only care about loops where the basepoint is a protocol symbol or associated type symbol whose protocol is part of the connected component. All other loops can be discarded since they do not encode redundancies that are relevant to us.
slavapestov
force-pushed
the
rqm-more-property-map-rewrite-loops
branch
from
e57d6ea
to
746f4a5
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.