Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Indexable protocols #4091

Merged
merged 2 commits into from Aug 9, 2016
Merged

Deprecate the Indexable protocols #4091

merged 2 commits into from Aug 9, 2016

Conversation

dabrahams
Copy link
Collaborator

These should really never be used except by the standard library

Using them is always a mistake; the user should choose the corresponding
Collection protocol instead.
@dabrahams
Copy link
Collaborator Author

@swift-ci Please test and merge

1 similar comment
@dabrahams
Copy link
Collaborator Author

@swift-ci Please test and merge

@dabrahams
Copy link
Collaborator Author

@swift-ci Please test Linux platform

@CodaFi
Copy link
Member

CodaFi commented Aug 8, 2016

Drive-by rebuild.

@swift-ci please test Linux platform.

@dabrahams
Copy link
Collaborator Author

It keeps timing out?!

@swift-ci Please test Linux platform

It's important to let people know that, in contrast with existing
practice in other frameworks, we really are going to remove the
deprecated API, and soon.
@dabrahams
Copy link
Collaborator Author

@swift-ci Please test and merge

@dabrahams
Copy link
Collaborator Author

It keeps timing out?!

@swift-ci Please test Linux platform

@dabrahams
Copy link
Collaborator Author

@swift-ci Please test and merge

@jrose-apple
Copy link
Contributor

Would renamed: help here? IIRC the diagnostics for deprecated+renamed+message are reasonable.

@dabrahams
Copy link
Collaborator Author

@jrose-apple Actually you have to choose between renamed and a message. The compiler will eat it, but will only give you one.

@dabrahams
Copy link
Collaborator Author

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor

Hm, okay. We definitely do both for unavailable, but maybe the diagnostic was getting too complicated for deprecated.

@dabrahams dabrahams merged commit b23af7c into master Aug 9, 2016
@jrose-apple
Copy link
Contributor

It turns out this commit was the cause of the timeouts—the parse_stdlib_*.sil tests are choking for whatever reason. Investigating.

@jrose-apple
Copy link
Contributor

…okay, -parse-sil really shouldn't emit availability warnings. That's all it is.

@jrose-apple jrose-apple deleted the deprecate-indexable branch August 17, 2016 01:25
kateinoigakukun pushed a commit that referenced this pull request Aug 31, 2022
[pull] swiftwasm from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants