Fix invalid warning for enum cases named self #41520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @xedin @jackgmarch since you all worked on the original |
|
@swift-ci please test |
apple#37992 introduced a warning when you were likely to confuse `self` with `TypeName.self`, this also applied to enum cases that were named `self`, these cases should not be easily confused at call sites since their use requires prefixing them with a `.`. There was also no way to avoid this warning since other syntax such as `TypeName.self`, which produces the enum type instead, or `` TypeName`.self` `` which produced the same warning again. Fixes https://bugs.swift.org/browse/SR-15691
keith
force-pushed
the
ks/fix-invalid-warning-for-enum-cases-named-self
branch
from
93cfaab
to
7ef6486
Compare
|
@swift-ci please test |
|
Hoping to cherry pick this into 5.6 in #41529 |
DougGregor
pushed a commit
that referenced
this pull request
Mar 23, 2022
#37992 introduced a warning when you were likely to confuse `self` with `TypeName.self`, this also applied to enum cases that were named `self`, these cases should not be easily confused at call sites since their use requires prefixing them with a `.`. There was also no way to avoid this warning since other syntax such as `TypeName.self`, which produces the enum type instead, or `` TypeName.`self` `` which produced the same warning again. Fixes https://bugs.swift.org/browse/SR-15691 (cherry picked from commit f6b2e2e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#37992 introduced a warning when you
were likely to confuse
selfwithTypeName.self, this also applied toenum cases that were named
self, these cases should not be easilyconfused at call sites since their use requires prefixing them with a
.. There was also no way to avoid this warning since other syntax suchas
TypeName.self, which produces the enum type instead, orTypeName.`self`which produced the same warning again.Fixes #57970