Fix this to not die on the OVEs from collection upcasts. #4329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For now, smoke testing to find the validation tests that will catch this. @swift-ci Please smoke test. |
|
@rjmccall I added a validation crasher for this last week that you'll want to switch to being a not-expected-to-crash. Since this is the first such crasher fixed you'll need to create the *_fixed directory for these: validation-test/Sema/type_checker_crashers/rdar27815848.swift |
rjmccall
force-pushed
the
collection-upcast-oves
branch
from
fe25a5b
to
e360d7f
Compare
|
Yeah, that was the test I was looking for. Wanted to see if there were others. @swift-ci Please smoke test. |
|
@swift-ci test |
|
Okay, the full test is passing but the smoke test failed to update the flag. Some admin should force-merge this. |
|
LGTM. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-2288)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.