Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rephrase diagnostic #4587

Closed
wants to merge 1 commit into from
Closed

rephrase diagnostic #4587

wants to merge 1 commit into from

Conversation

hkareemllc
Copy link

Removed Objective-C from diagnostic message to so that it is generic.
Resolves SR-2409.

@jrose-apple
Copy link
Contributor

Hm, that's a little more than I meant. It's still useful to know that it's an imported C or Objective-C module instead of a Swift module. How about using theASTContext.LangOpts.EnableObjCInterop to choose between "C" and "Objective-C"?

@jrose-apple
Copy link
Contributor

Also, can you make the commit message a little more descriptive, and reference the SR there? That way people don't have to come find the pull request or look at the diff to see what's going on.

@jrose-apple
Copy link
Contributor

Thanks for taking this!

@hkareemllc
Copy link
Author

@jrose-apple so would i change it to could not build theASTContext.LangOpts.EnableObjCInterop module 'Foo'?

@jrose-apple
Copy link
Contributor

Not quite. If you look at the other diagnostics, you can see that some of them take arguments and use a %select construct to choose which text to show. So we'd pass the value of EnableObjCInterop along when we emit the diagnostic, and get the correct text out.

@CodaFi
Copy link
Member

CodaFi commented Jan 13, 2017

@hkareem2222 Ping.

@CodaFi
Copy link
Member

CodaFi commented Mar 16, 2017

This pull request has been superseded by #8147. Thank you for your patch @hkareem2222

@CodaFi CodaFi closed this Mar 16, 2017
kateinoigakukun added a commit that referenced this pull request Aug 31, 2022
[pull] swiftwasm from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants