[Sema] Fix SR-1681 spurious "unused result" warning #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An OptionalEvaluationExpr can have a CallExpr directly as its SubExpr, if the CallExpr already has optional type. extends ea52d4f
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends ea52d4f to support methods returning optional types.
When an optionally chained method already has an optional return type, the corresponding CallExpr is not wrapped in an
InjectIntoOptionalExpr. Instead anOptionalEvaluationExprcan have aCallExprdirectly as its SubExpr in this case.I'm not sure if the cast to
CallExpris even needed, but put it in for safety reasons. If someone can confirm whether or not it makes sense to keep it in there, and if there are other types that could be relevant as a SubExpr, please let me know.Resolves SR-1681.