Don't attempt a value conversion without a valid conversion pair #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test. |
Previously this would crash when invalid tuple conversions were encountered because we would try to convert NULL Expr nodes.
CodaFi
force-pushed
the
you-cant-have-a-con-version-without-the-confidence
branch
from
bfba8c6
to
ff2289d
Compare
|
@swift-ci please smoke test and merge. |
|
Dictionary test seems to fail for everybody? // @gribozavr |
|
@CodaFi Does not seem to fail on master. |
|
I think Harlan's pull request failed the same test, but nevertheless let's see what happens now @swift-ci please smoke test Linux platform. |
|
@swift-ci please smoke test Linux platform. |
|
That's better ⛵ |
CodaFi
deleted the
you-cant-have-a-con-version-without-the-confidence
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this would crash when invalid tuple conversions were encountered in the middle of collection upcasts because we were trying to convert with NULL
Exprnodes.Resolves SR-2585 and rdar://problem/28207648.