[stdlib] Mark UnicodeScalar.utf16 and UnicodeScalar.UTF16View as public #4929

Merged
merged 2 commits into from Sep 26, 2016

Projects

None yet

8 participants

@eliperkins
Contributor
eliperkins commented Sep 22, 2016 edited

UnicodeScalar.utf16 and UnicodeScalar.UTF16View do not have access modifiers and are therefore internal. This marks them as public.

Resolves SR-2627.

@eliperkins eliperkins Mark UnicodeScalar.utf16 and UnicodeScalar.UTF16View as public
Implements SR-2627
9009eaf
@eliperkins
Contributor

@swift-ci Please smoke test

@modocache
Collaborator

@swift-ci please smoke test

@gottesmm
Member

@moiseev This is an API change, no? What is the policy around this?

@moiseev moiseev changed the title from Mark UnicodeScalar.utf16 and UnicodeScalar.UTF16View as public to [stdlib] Mark UnicodeScalar.utf16 and UnicodeScalar.UTF16View as public Sep 22, 2016
@moiseev
Member
moiseev commented Sep 22, 2016

Thanks @gottesmm. This is indeed an API change and as such should go through the evolution. On the other hand, it can be considered a bug-fix.
@eliperkins can you initiate a swift-evolution discussion?

stdlib/public/core/UnicodeScalar.swift
- struct UTF16View {
- var value: UnicodeScalar
+ public struct UTF16View {
+ public var value: UnicodeScalar
@moiseev
moiseev Sep 22, 2016 Member

This property should remain internal, actually.

@eliperkins
eliperkins Sep 22, 2016 Contributor

Addressed in 4a6d368

@eliperkins
Contributor

can you initiate a swift-evolution discussion?

@moiseev Sure thing! Better to kick it off on the mailing list or just by opening up a proposal on swift-evolution?

@moiseev
Member
moiseev commented Sep 22, 2016

Mailing list. If it ends up being considered a bug-fix, it might not even need a formal proposal.
Thanks!

@eliperkins eliperkins Keep `value` as only available internally
4a6d368
@eliperkins
Contributor

Kicked off the email on swift-evolution. Thanks!

@eliperkins
Contributor

@swift-ci please smoke test

@dabrahams
Member

@swift-ci Please smoke test and merge

@moiseev
Member
moiseev commented Sep 26, 2016

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 0ab20e8 into apple:master Sep 26, 2016

2 of 3 checks passed

Test and Merge (smoke test) Build started.
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform (smoke test)
Details
@eliperkins eliperkins deleted the eliperkins:SR-2627-utf16-access-modifier branch Sep 26, 2016
@lattner
Contributor

Please add an entry to the changelog, thanks!

Contributor

Should it be added under the Swift 3.1 section on the changelog?

@gribozavr
Collaborator

Could you add some tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment