[Driver] Begin testing -driver-show-incremental #5128
Conversation
|
|
||
| // CHECK-FIRST-NOT: warning | ||
| // CHECK-FIRST: Handled main.swift | ||
| // CHECK-FIRST: Handled other.swift | ||
| // CHECK-FIRST: Queuing main.swift (initial) |
There was a problem hiding this comment.
Hm. I'm a little concerned about merging the two output streams this way. This seems like odd behavior, seeing the "Queuing" line after the things are actually handled.
There was a problem hiding this comment.
I agree. I've moved the test to its own file. My plan is to, in future commits, add files like test/Driver/Dependencies/driver-show-incremental-*.swift for each interesting output in -driver-show-incremental. Does that sound good?
There was a problem hiding this comment.
Yeah, that should be sufficient. I like the idea of it just coming with any test added to Driver/Dependencies/, but in practice it seems like more trouble than it's worth.
https://bugs.swift.org/browse/SR-2855 describes additional functionality to be added to `-driver-show-incremental`. That option is not currently tested anywhere. Begin adding tests that mirror incremental compilation tests, like `test/Driver/Dependencies/mutual.swift`.
modocache
force-pushed
the
sr-2855-driver-show-incremental-tests
branch
from
abe6158
to
f2953de
Compare
|
Cool, thanks! I'll go ahead and merge this, then:
|
|
@swift-ci Please test and merge |
|
I don't actually expect SR-2855 to intersect much with other tests; those are the cases where nothing incremental is happening! |
|
Ah, hmm, good point. Then I guess this is sort of tangential -- although it is helping me understand The build failures are due to an unrelated error in SwiftPM. I'll try to merge again later. |
|
@swift-ci please test and merge |
|
@swift-ci please clean test and merge |
SR-2855 describes additional functionality to be added to
-driver-show-incremental. That option is not currently tested anywhere. Using the option does not interfere with existing incremental compilation tests, so begin adding it to tests, starting with mutual dependencies tests.I considered adding new, isolated tests for this option, but adding it to existing tests results in less setup code and test boilerplate.
A first step in addressing SR-2855.
@jrose-apple I thought adding some tests for
-driver-show-incrementalwould be a good start. What do you think of adding it to the existing tests? If that sounds good, I'll add it to more tests, then update theCHECKs once I've implemented SR-2855.