[stdlib] Only add Apple reflection test targets #5175
Conversation
|
@swift-ci Please test |
|
/cc @erg |
| "swiftSwiftReflectionTest${VARIANT_SUFFIX}" | ||
| "swift-reflection-test${VARIANT_SUFFIX}") | ||
| endforeach() | ||
| if("${SDK}" IN_LIST SWIFT_APPLE_PLATFORMS) |
There was a problem hiding this comment.
Where does SWIFT_APPLE_PLATFORMS come from?
There was a problem hiding this comment.
Apologies, looks like I lost a line of source code when I split up #4972. I amended the commit with the missing CMake changes that add SWIFT_APPLE_PLATFORMS. 😨
modocache
force-pushed
the
cmake-reflection-test-macos-host-android
branch
from
619b25d
to
aef94ff
Compare
When building on a macOS host, and when `SWIFT_INCLUDE_TESTS` is specified, the `swiftSwiftReflectionTest` target is added to all platforms. However, this target has a dependency upon Foundation, which is not available on non-Apple platforms. Use `add_swift_library`'s `TARGET_SDKS` parameter and other gating logic to ensure the target is only added for platforms that actually have Darwin available.
modocache
force-pushed
the
cmake-reflection-test-macos-host-android
branch
from
aef94ff
to
c42d0d2
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Looks good if it builds clean! |
|
Build failed |
|
@swift-ci Please clean test |
|
Thanks! |
|
Is there any cross-platform subset of |
|
I really dislike that we have this target code in the Swift tools directory. We should consider sinking this into a stdlib/tools directory or something like that. tools IMO should be meant only for "build tools", not for "target tools". |
|
I hope that at some point we follow the separate cmake cross compilation model for the stdlib and then sink this code into there. |
When building on a macOS host, and when
SWIFT_INCLUDE_TESTSis specified, theswiftSwiftReflectionTesttarget is added to all platforms. However, this target has a dependency upon Foundation, which is not available on non-Apple platforms.Use
add_swift_library'sTARGET_SDKSparameter and other gating logic to ensure the target is only added for platforms that actually have Darwin available.This was pulled out of the larger pull request #4972, which addresses SR-1362.