[IRGen] Emit calls to objc_allocWithZone(cls) when allocating obj-c objects. #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test As this is my first change to IRGen and thus a part of the code I'm much less familiar with, I'd appreciate any code reviews. Thanks! |
|
Paging @rjmccall to the github courtesy phone. |
|
@swift-ci please smoke test |
|
Looks good to me. |
|
Thanks, Greg! |
|
Looks good to me, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces objc_msgSend of +allocWithZone: with a direct C call to objc_allocWithZone(cls) when allocating obj-c objects.
Resolves SR-2875.