Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SourceKit] The initial implementation of range-info request. #5634

Merged
merged 1 commit into from Nov 3, 2016
Merged

[SourceKit] The initial implementation of range-info request. #5634

merged 1 commit into from Nov 3, 2016

Conversation

nkcsgexi
Copy link
Member

@nkcsgexi nkcsgexi commented Nov 3, 2016

Like cursor-info, range info (""source.request.cursorinfo"") answers some
questions clients have for a code snippet under selection, for instance, the type of a selected
expression. This commit implements this new quest kind and provides two
simple information about the selected code: (1) the kind of the
snippet, currently limited to single-statement and expression; and (2)
the type of the selected expression. Gradually, we will enrich the
response to provide more insight into the selected code snippet.

Like cursor-info, range info (""source.request.cursorinfo"") answers some
questions clients have for a code snippet under selection, for instance, the type of a selected
expression. This commit implements this new quest kind and provides two
simple information about the selected code: (1) the kind of the
snippet, currently limited to single-statement and expression; and (2)
the type of the selected expression. Gradually, we will enrich the
response to provide more insight into the selected code snippet.
@nkcsgexi
Copy link
Member Author

nkcsgexi commented Nov 3, 2016

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 12fea93 into apple:master Nov 3, 2016
@modocache
Copy link
Collaborator

modocache commented Nov 5, 2016

This is awesome, thanks!

Would it be possible to add documentation for new requests as they're added? SR-2117 tracks documenting the existing SourceKit request types. It would be great to keep that list of undocumented request types from growing. As a contributor I find it pretty difficult to add documentation for request types based on just their implementation and tests.

@nkcsgexi
Copy link
Member Author

nkcsgexi commented Nov 7, 2016

@modocache Sure, more available documentation is always a good idea. Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants