[Sema] Skip UNCHECKED_EXPRs in ErrorHandlingWalker #5751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
JaSpa
reviewed
Nov 13, 2016
| #define UNCHECKED_EXPR(KIND, BASE) \ | ||
| else if (isa<KIND##Expr>(E)) return {false, nullptr}; | ||
| #include "swift/AST/ExprNodes.def" | ||
| #undef UNCHECKED_EXPR |
There was a problem hiding this comment.
The #undef isn't needed as ExprNodes.def #undefs everything in the end
On rare occasions, malformed programs can allow an UNCHECKED_EXPR (e.g. ArrowExpr) to escape type checking. The erroneous expression may have sub-expressions which aren't fully typechecked, so we can't safely visit them.
jtbandes
force-pushed
the
validation-ignore-unchecked
branch
from
d57dbe4
to
dfea7ee
Compare
|
@swift-ci please smoke test |
|
Timeout isn't your fault. @swift-ci please smoke test Linux platform. |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On rare occasions, malformed programs can allow an UNCHECKED_EXPR (e.g. ArrowExpr) to escape type checking. The erroneous expression may have sub-expressions which aren't fully typechecked, so we can't safely visit them.
Resolves at least 1 compiler crasher. CI will tell me if there are any others. 馃槂