-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serialization] Pass along allow errors/skip bodies flags #59739
Draft
bnbarham
wants to merge
1
commit into
swiftlang:main
Choose a base branch
from
bnbarham:pass-allow-errors-to-interface-building
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
test/ModuleInterface/allow-errors-applies-to-interface.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // RUN: %empty-directory(%t) | ||
| // RUN: split-file %s %t | ||
|
|
||
| // RUN: %target-swift-frontend -module-name B -emit-module -emit-module-path %t/mods/B.swiftmodule -experimental-allow-module-with-compiler-errors -experimental-skip-all-function-bodies -module-cache-path %t/mcp %t/B.swift | ||
| // RUN: %target-swift-frontend -module-name C -emit-module -emit-module-path %t/mods/C.swiftmodule -experimental-allow-module-with-compiler-errors -experimental-skip-all-function-bodies -I%t/mods -module-cache-path %t/mcp %t/C.swift | ||
| // RUN: %target-swift-frontend -module-name C -emit-module -emit-module-path %t/mods/C.swiftmodule -experimental-allow-module-with-compiler-errors -experimental-skip-all-function-bodies -I%t/mods -module-cache-path %t/mcp %t/C.swift | ||
|
|
||
| //--- mods/A.swiftinterface | ||
| // swift-interface-format-version: 1.0 | ||
| // swift-module-flags: -swift-version 5 -enable-library-evolution -module-name A -debug-forbid-typecheck-prefix NOTYPECHECK | ||
|
|
||
| import Swift | ||
| import B | ||
|
|
||
| public struct FromA: ProtoFromB { | ||
| public func badMethod(arg: Int) -> Int | ||
| } | ||
|
|
||
| @inlinable public func topLeveLFromA() -> Int { | ||
| let NOTYPECHECK_local = 1 | ||
| return NOTYPECHECK_local | ||
| } | ||
|
|
||
| //--- B.swift | ||
| public protocol ProtoFromB { | ||
| func badMethod(arg: missing) -> Int | ||
| } | ||
|
|
||
| public struct StructFromB { | ||
| public field: missing | ||
| } | ||
|
|
||
| //--- C.swift | ||
| import A | ||
| import B | ||
|
|
||
| public func fromC(a: FromA) { | ||
| _ = a.badMethod(arg: 1) | ||
| _ = StructFromB() | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // RUN: %empty-directory(%t) | ||
| // RUN: mkdir -p %t/mods | ||
| // RUN: split-file %s %t | ||
|
|
||
| // RUN: %target-swift-frontend -module-name A -emit-module -emit-module-path %t/mods/A.swiftmodule -experimental-allow-module-with-compiler-errors %t/A.swift | ||
| // RUN: %target-swift-frontend -module-name B -emit-module -emit-module-path %t/mods/B.swiftmodule -experimental-allow-module-with-compiler-errors -I%t/mods %t/B.swift 2>&1 | %FileCheck %s | ||
|
|
||
| //--- A.swift | ||
| public struct StructFromA { | ||
| public func badMethod(arg: missing) {} | ||
| } | ||
|
|
||
| //--- B.swift | ||
| import A | ||
|
|
||
| public func test() { | ||
| // The init is internal so we expect to get a diagnostic for that. But | ||
| // deserializing `StructFromA` could potentially output a diagnostic for the | ||
| // error type on `field`. Make sure that we don't crash and that there is a | ||
| // diagnostic for the internal init. | ||
| _ = StructFromA() | ||
| // CHECK: error: 'StructFromA' initializer is inaccessible due to 'internal' protection level | ||
| } | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to limit this to
Allonly. Also need to consider how this impacts the hash - modules without skip/errors should be used by compilations without, but definitely not the other way around.