[Serialization] Pass along allow errors/skip bodies flags #59739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building swiftinterface's should use the allow errors and skip bodies flags of the main compilation. Consider a swiftinterface A that depends on a module B. If B is built allowing errors then deserialization while building the module for A should not fail if there are in fact errors. Resolves rdar://84515859.
|
@swift-ci please test |
bnbarham
commented
Jun 28, 2022
| @@ -1364,6 +1366,15 @@ void InterfaceSubContextDelegateImpl::inheritOptionsForBuildingInterface( | |||
| std::string pair = (llvm::Twine(lhs) + "=" + rhs).str(); | |||
| GenericArgs.push_back(ArgSaver.save(pair)); | |||
| }); | |||
|
|
|||
| genericSubInvocation.getTypeCheckerOptions().SkipFunctionBodies = | |||
There was a problem hiding this comment.
Probably want to limit this to All only. Also need to consider how this impacts the hash - modules without skip/errors should be used by compilations without, but definitely not the other way around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building swiftinterface's should use the allow errors and skip bodies
flags of the main compilation. Consider a swiftinterface A that depends
on a module B. If B is built allowing errors then deserialization while
building the module for A should not fail if there are in fact errors.
Resolves rdar://84515859.