Fix two opaque return type bugs #60044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
fix-two-opaque-return-type-bugs
branch
from
e3482a4
to
e766f95
Compare
slavapestov
commented
Jul 13, 2022
| // If we don't have substitutions, this is an opaque archetype from | ||
| // another declaration being manipulated, and not an erasure of a | ||
| // concrete type to an opaque type inside its defining declaration. | ||
| if (!substitutions.empty()) { |
There was a problem hiding this comment.
I don't think there is a better way to check this unfortunately...
slavapestov
requested review from
hborla and
xedin
and removed request for
hborla
|
@swift-ci Please smoke test |
This cannot be represented in the ABI because we expect that the opaque return type can be instantiated from the generic arguments of its declaring context. Reconstructing type metadata for the DynamicSelfType would require opaque return type instantiation to also take the self *value*. Fixes rdar://72407668 / apple#56367
…tion Move the check where we insert UnderlyingToOpaqueExpr earlier in coerceToType(). Otherwise, returning a metatype or function type would attempt to perform a conversion instead of building a UnderlyingToOpaqueExpr. Fixes part of apple#60038.
slavapestov
force-pushed
the
fix-two-opaque-return-type-bugs
branch
from
e766f95
to
78e9af7
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
somekeyword in a closure type #64799