Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeCompletion] Suggest in keyword in for … in loop #60207

Merged
merged 2 commits into from
Jul 25, 2022
Merged

[CodeCompletion] Suggest in keyword in for … in loop #60207

merged 2 commits into from
Jul 25, 2022

Conversation

simanerush
Copy link
Member

Resolves #58633.

@xedin xedin requested review from ahoppen and rintaro July 23, 2022 22:38
@ahoppen
Copy link
Member

ahoppen commented Jul 24, 2022

@swift-ci Please smoke test

ahoppen
ahoppen approved these changes Jul 24, 2022
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to the Swift compiler. This is looking great 👍

If you want to mark this as ready for review, I think it’s ready to be merged.

@simanerush simanerush marked this pull request as ready for review July 24, 2022 21:14
@simanerush
Copy link
Member Author

@ahoppen I just ran clang-format on these changes and marked as ready for review. Thank you for quick feedback!

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test

@ahoppen ahoppen merged commit 837ce17 into swiftlang:main Jul 25, 2022
@simanerush simanerush deleted the code-completion-foreach branch July 25, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucianoPAlmeida LucianoPAlmeida LucianoPAlmeida left review comments

@AnthonyLatsis AnthonyLatsis AnthonyLatsis left review comments

@ahoppen ahoppen ahoppen approved these changes

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggest in keyword in for … in loop
4 participants
@simanerush @ahoppen @AnthonyLatsis @LucianoPAlmeida