Apply @preconcurrency to typealiases at the point of use #60596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use. When referencing a `@preconcurrency` typealias from code that does not require strict concurrency, strip off `@Sendable` and global actor types. This is consistent with references to functions/properties/etc. that are `@preconcurrency`. Fixes apple#60487, rdar://98343624. (cherry picked from commit 5b88b96)
…ency` decls When a `@preconcurrency` typealias is used within the type of a `@preconcurrency` declaration, such as a function, do not strip concurrency-related types, because the stripping will happen in the outer declaration. Fixes apple#60488. (cherry picked from commit 2fbdad7)
(cherry picked from commit 5299326)
|
@swift-ci please test |
hborla
approved these changes
Aug 17, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When referencing a
@preconcurrencytypealias from code that does notrequire strict concurrency, strip off
@Sendableand global actortypes. This is consistent with references to functions/properties/etc.
that are
@preconcurrency.Fixes #60487, #60488., rdar://98343624.